Re: [PATCH] libxfs: remove unused libxfs

xfs

Re: [PATCH] libxfs: remove unused libxfs_iget arg

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH] libxfs: remove unused libxfs_iget arg
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 27 Sep 2016 19:09:48 -0700
Cc:	xfs-oss <xfs@xxxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<355fec5f-f7ef-8472-c71b-7bfa9d9ab8bd@xxxxxxxxxx>
References:	<355fec5f-f7ef-8472-c71b-7bfa9d9ab8bd@xxxxxxxxxx>
User-agent:	Mutt/1.6.1 (2016-04-27)

On Tue, Sep 27, 2016 at 01:10:28PM -0500, Eric Sandeen wrote:
> libxfs_iget() is always called with bno == 0.
> Which is probably a good thing, because it then passes
> bno to xfs_iread as iget_flags!
> 
> So remove the libxfs_iget arg, and explicitly pass
> 0 to xfs_iread for flags.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> (or should we just rename/re-type bno to a flags arg?)

Killing it seems fine to me.  Any argument not actually used is just
asking for bugs like the one you just fixed.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] libxfs: remove unused libxfs_iget arg, Eric Sandeen Re: [PATCH] libxfs: remove unused libxfs_iget arg, Christoph Hellwig <=

Previous by Date:	Re: Clarification required about xfs_metadump and xfs_mdrestore, murali krishna
Next by Date:	PVC/PE colorful co-extrusion mould, gsmold160801@xxxxxxx
Previous by Thread:	[PATCH] libxfs: remove unused libxfs_iget arg, Eric Sandeen
Next by Thread:	Right Contacts, Amy Walsh
Indexes:	[Date] [Thread] [Top] [All Lists]