xfs
[Top] [All Lists]

Re: [PATCH] xfs_quota: Enable 3 more foreign commands

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_quota: Enable 3 more foreign commands
From: "Bill O'Donnell" <billodo@xxxxxxxxxx>
Date: Fri, 16 Sep 2016 08:30:27 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5fe315ee-1198-ca43-16a0-13562ced179e@xxxxxxxxxx>
References: <5fe315ee-1198-ca43-16a0-13562ced179e@xxxxxxxxxx>
User-agent: Mutt/1.7.0 (2016-08-17)
On Thu, Sep 15, 2016 at 04:53:51PM -0500, Eric Sandeen wrote:
> Enable restore, limit, and timer.
> 
> Unsupported commands remain, for lack of kernel support, generally:
> warn, quot,, enable, disable, and remove.
> 
> xfs_quota> report
> User quota on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>                                Blocks                     
> User ID          Used       Soft       Hard    Warn/Grace     
> ---------- -------------------------------------------------- 
> root               13          0          0     00 [--------]
> 
> xfs_quota> restore -f quotadump
> xfs_quota> report
> User quota on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>                                Blocks                     
> User ID          Used       Soft       Hard    Warn/Grace     
> ---------- -------------------------------------------------- 
> root               13          0          0     00 [--------]
> testuser            0      16384      32768     00 [--------]
> fsgqa               0     102400     112640     00 [--------]
> 
> xfs_quota> limit bsoft=200m fsgqa
> 
> xfs_quota> report 
> User quota on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>                                Blocks                     
> User ID          Used       Soft       Hard    Warn/Grace     
> ---------- -------------------------------------------------- 
> root               13          0          0     00 [--------]
> testuser            0      16384      32768     00 [--------]
> fsgqa               0     204800     112640     00 [--------]
> 
> xfs_quota> state -u
> User quota state on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>   Accounting: ON
>   Enforcement: ON
>   Inode: #12 (16 blocks, 1 extents)
> Blocks grace time: [7 days]
> Inodes grace time: [7 days]
> 
> xfs_quota> timer -b 3days
> xfs_quota> state -u
> User quota state on /mnt/test2/git/xfsprogs/mnt (/dev/loop0)
>   Accounting: ON
>   Enforcement: ON
>   Inode: #12 (16 blocks, 1 extents)
> Blocks grace time: [3 days]
> Inodes grace time: [7 days]
> Realtime Blocks grace time: [--------]
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Reviewed-by: Bill O'Donnell <billodo@xxxxxxxxxx>

> ---
> 
> diff --git a/quota/edit.c b/quota/edit.c
> index e5ddc8c..36b327a 100644
> --- a/quota/edit.c
> +++ b/quota/edit.c
> @@ -709,6 +709,7 @@ edit_init(void)
>       _("[-g|-p|-u] bsoft|bhard|isoft|ihard|rtbsoft|rtbhard=N -d|id|name");
>       limit_cmd.oneline = _("modify quota limits");
>       limit_cmd.help = limit_help;
> +     limit_cmd.flags = CMD_FLAG_FOREIGN_OK;
>  
>       restore_cmd.name = "restore";
>       restore_cmd.cfunc = restore_f;
> @@ -716,6 +717,7 @@ edit_init(void)
>       restore_cmd.argmax = -1;
>       restore_cmd.args = _("[-g|-p|-u] [-f file]");
>       restore_cmd.oneline = _("restore quota limits from a backup file");
> +     restore_cmd.flags = CMD_FLAG_FOREIGN_OK;
>  
>       timer_cmd.name = "timer";
>       timer_cmd.cfunc = timer_f;
> @@ -724,6 +726,7 @@ edit_init(void)
>       timer_cmd.args = _("[-bir] [-g|-p|-u] value");
>       timer_cmd.oneline = _("set quota enforcement timeouts");
>       timer_cmd.help = timer_help;
> +     timer_cmd.flags = CMD_FLAG_FOREIGN_OK;
>  
>       warn_cmd.name = "warn";
>       warn_cmd.cfunc = warn_f;
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>