xfs
[Top] [All Lists]

Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs
From: Dan Williams <dan.j.williams@xxxxxxxxx>
Date: Thu, 15 Sep 2016 10:01:03 -0700
Cc: Linux MM <linux-mm@xxxxxxxxx>, "linux-nvdimm@xxxxxxxxxxxx" <linux-nvdimm@xxxxxxxxxxxx>, david <david@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UpQDRD1ZkI7KmEZPXHPvVVnLHImgUEEhu9h867fwGkg=; b=GI9H4WdBhZQ2+DxfK1iu5cj6LG820GT1BbshuDCKVqe1xb3yEUY5vEUW5Mr+oiLtUH J1Cs0SBtZPz/VF1UAEoMnakOo0Fc/bjr+o33nAmMs6r7Ngy2MCFW5R9Glsvcx8ZxxiFg B7I+VM5PIkN9kO0wF8NBrjF2+3YaQtLuUzR3iCOZnfDejC188tIorMIbfL2F0HgVvlbw EH/rtmoGCLZaAkftYDEpGUSfBD3odXSUAX5nbivZaH5+xsxbHn13fM+U2kK79Xv9uxUB SBPVtzetAISFzOgyFnrufrB6V6IBIOTXHvux/g2qtMW5zTkpA5T714Hi/szo7ezTgjRo fGJQ==
In-reply-to: <20160915082615.GA9772@xxxxxx>
References: <147392246509.9873.17750323049785100997.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <147392247875.9873.4205533916442000884.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20160915082615.GA9772@xxxxxx>
On Thu, Sep 15, 2016 at 1:26 AM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Wed, Sep 14, 2016 at 11:54:38PM -0700, Dan Williams wrote:
>> The DAX property, page cache bypass, of a VMA is only detectable via the
>> vma_is_dax() helper to check the S_DAX inode flag.  However, this is
>> only available internal to the kernel and is a property that userspace
>> applications would like to interrogate.
>
> They have absolutely no business knowing such an implementation detail.

Hasn't that train already left the station with FS_XFLAG_DAX?

The other problem with hiding the DAX property is that it turns out to
not be a transparent acceleration feature.  See xfs/086 xfs/088
xfs/089 xfs/091 which fail with DAX and, as far as I understand, it is
due to the fact that DAX disallows delayed allocation behavior.

If behavior changes I think we should indicate that to userspace and
VM_DAX is certainly more useful to userspace than some of the other vm
internals we already export in those flags.

<Prev in Thread] Current Thread [Next in Thread>