Re: [PATCH 1/3] xfsprogs: populate fs table with xfs entries first, foreign entries last

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 9/14/16 12:50 PM, Eric Sandeen wrote:
>> @@ -113,8 +119,13 @@ path_f(
> Oops, I mentioned this to you as needed, but it's wrong, sorry.
> 
> Just drop this hunk, this is supposed to select path i, not iterate
> over anything.  Sorry for mentioning it.
> 
>> >            printf(_("value %d is out of range (0-%d)\n"),
>> >                    i, fs_count-1);
>> >    } else {
>> > -          fs_path = &fs_table[i];
>> > -          pathlist_f();
>> > +          for (i = 0; i < fs_count; i++) {
>> > +                  fs_path = &fs_table[i];
>> > +                  /* Table is ordered xfs first, then foreign */
>> > +                  if (fs_path->fs_flags & FS_FOREIGN && !foreign_allowed)
>> > +                          break;
>> > +                  pathlist_f();
>> > +          }
>> >    }
>> >    return 0;
>> >  }

Oh, right.  You need the test & break in print_f not path_f, otherwise:

# quota/xfs_quota -x
xfs_quota> print
Filesystem          Pathname
    /home               /dev/mapper/vg_bp05-lv_home
    /mnt/test2          /dev/sdc1
(F) /                   /dev/mapper/vg_bp05-lv_root
(F) /boot               /dev/sda1
(F) /mnt/test           /dev/sdb1
xfs_quota> 

"print" gives you foreign filesystems when you didn't ask for them.

-Eric