| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] [RFC] xfs: make xfs btree stats less huge |
| From: | Carlos Maiolino <cmaiolino@xxxxxxxxxx> |
| Date: | Tue, 13 Sep 2016 11:06:57 +0200 |
| Cc: | linux-xfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1473755322-883-1-git-send-email-david@xxxxxxxxxxxxx> |
| Mail-followup-to: | Dave Chinner <david@xxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| References: | <1473755322-883-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | NeoMutt/20160910 (1.7.0) |
On Tue, Sep 13, 2016 at 06:28:42PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Embedding a switch statement in every btree stats inc/add adds a lot > of code overhead to the core btree infrastructure paths. Stats are > supposed to be small and lightweight, but the btree stats have > become big and bloated as we've added more btrees. It needs fixing > because the reflink code will just add more overhead again. Talking about stats, is there any documentation for that? I was using the log stats while working on the fail_at_unmount hang, and I couldn't find anything other than looking into the code to see what each number means. Cheers -- Carlos |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH V4] xfs: Document error handlers behavior, Carlos Maiolino |
|---|---|
| Next by Date: | Re:Sincerely work with PCB Purchasers, market8@xxxxxxxxxxxxxx |
| Previous by Thread: | [PATCH] [RFC] xfs: make xfs btree stats less huge, Dave Chinner |
| Next by Thread: | Re: [PATCH] [RFC] xfs: make xfs btree stats less huge, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |