xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: fix exit code documentation in manpage

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] xfs_repair: fix exit code documentation in manpage
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 12 Sep 2016 09:03:25 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <62881d1e-8980-00c6-1d04-642a49b3b252@xxxxxxxxxx>
References: <62881d1e-8980-00c6-1d04-642a49b3b252@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
On 9/12/16 7:35 AM, Eric Sandeen wrote:
> xfs_repair cannot proceed with a dirty log, and exits with
> a status code of 2 in that case; fix the manpage to
> reflect this.
> 
> (This has been the case for years, but was never documented).
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Sorry, I missed Zorro's earlier patch,

xfs_repair: update the manual content about xfs_repair exit status

So drop this one, i'll go review Zorro's patch.

-Eric


> ---
> 
> diff --git a/man/man8/xfs_repair.8 b/man/man8/xfs_repair.8
> index 1b4d9e3..57c970a 100644
> --- a/man/man8/xfs_repair.8
> +++ b/man/man8/xfs_repair.8
> @@ -509,7 +509,9 @@ If the directory were small, the message would read 
> "junking entry ...".
>  will return a status of 1 if filesystem corruption was detected and
>  0 if no filesystem corruption was detected.
>  .B xfs_repair
> -run without the \-n option will always return a status code of 0.
> +run without the \-n option will return a status code of 2 if the log is
> +dirty and needs to be replayed, otherwise it will always return a status
> +code of 0.
>  .SH BUGS
>  The filesystem to be checked and repaired must have been
>  unmounted cleanly using normal system administration procedures
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

<Prev in Thread] Current Thread [Next in Thread>