xfs
[Top] [All Lists]

Re: [PATCH 4/6] fs: add iomap_file_dirty

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 4/6] fs: add iomap_file_dirty
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 11 Sep 2016 05:58:33 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, david@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160906173428.GG16696@xxxxxxxxxxxxxxxx>
References: <147216784041.525.7722906502172299465.stgit@xxxxxxxxxxxxxxxx> <147216786712.525.5901639662288553230.stgit@xxxxxxxxxxxxxxxx> <20160905145751.GC7662@xxxxxxxxxxxxx> <20160906173428.GG16696@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
On Tue, Sep 06, 2016 at 10:34:28AM -0700, Darrick J. Wong wrote:
> > > XXX: might want a bigger name, and possible a better implementation
> > > that doesn't require two lookups in the radix tree.
> > 
> > And these need to be looked into.  I can take a stab at it, but I need
> > to get a few other things off my plate first.
> 
> Yeah.  It works well enough for unsharing blocks, if inefficiently.
> 
> Not sure what "a bigger name" means, though.  I tried feeding the
> function prototype through figlet but gcc didn't like that. ;)

That should have been "better", sorry.

<Prev in Thread] Current Thread [Next in Thread>