On Fri, Sep 09, 2016 at 09:13:26AM +1000, Dave Chinner wrote:
> On Thu, Sep 08, 2016 at 12:14:04PM -0700, Darrick J. Wong wrote:
> > On Tue, Sep 06, 2016 at 08:21:55AM -0700, Christoph Hellwig wrote:
> > > > + __uint64_t cui_id;
> > > > + struct xfs_ail_cursor cur;
> > > > + struct xfs_ail *ailp = log->l_ailp;
> > > > +
> > > > + cud_formatp = item->ri_buf[0].i_addr;
> > > > + ASSERT(item->ri_buf[0].i_len == sizeof(struct
> > > > xfs_cud_log_format));
> > >
> > > Should we return -EFSCORRUPTED here instead?
> >
> > Yes. The RUD recovery routine should probably get that change too.
> >
> > > > + /* XXX: do nothing for now */
> > >
> > > What else would be do in the future here?
> > >
> > > > +static void
> > > > +xfs_trans_set_refcount_flags(
> > > > + struct xfs_phys_extent *refc,
> > > > + enum xfs_refcount_intent_type type)
> > > > +{
> > > > + refc->pe_flags = 0;
> > > > + switch (type) {
> > > > + case XFS_REFCOUNT_INCREASE:
> > > > + refc->pe_flags |= XFS_REFCOUNT_EXTENT_INCREASE;
> > > > + break;
> > > > + case XFS_REFCOUNT_DECREASE:
> > > > + refc->pe_flags |= XFS_REFCOUNT_EXTENT_DECREASE;
> > > > + break;
> > > > + case XFS_REFCOUNT_ALLOC_COW:
> > > > + refc->pe_flags |= XFS_REFCOUNT_EXTENT_ALLOC_COW;
> > > > + break;
> > > > + case XFS_REFCOUNT_FREE_COW:
> > > > + refc->pe_flags |= XFS_REFCOUNT_EXTENT_FREE_COW;
> > > > + break;
> > >
> > > Is there any good reasons to use a type enum in core, but flags on
> > > disk?
> >
> > I suppose since log structures aren't guaranteed to be platform agnostic
> > it's fine to just copy in the in-core enum here.
>
> Carfeul there - enums are not defined to have a fixed size and so
> can change from compiler version to compiler version. IOWs, the
> enum values can be written idirectly to an on-disk structure, but
> the on-disk structure should not be using the enum as the type
> definition for whatever gets stored on disk.
<nod> I left the fields (and the #define flags) definitions alone,
so it's only writing enum values indirectly into a fixed size (u32)
variable on-disk.
i.e. I'm not using enums in the on-disk structure definitions.
--D
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
|