xfs
[Top] [All Lists]

Re: [PATCH 4/6] fs: add iomap_file_dirty

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] fs: add iomap_file_dirty
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Tue, 6 Sep 2016 10:34:28 -0700
Cc: Christoph Hellwig <hch@xxxxxx>, david@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160905145751.GC7662@xxxxxxxxxxxxx>
References: <147216784041.525.7722906502172299465.stgit@xxxxxxxxxxxxxxxx> <147216786712.525.5901639662288553230.stgit@xxxxxxxxxxxxxxxx> <20160905145751.GC7662@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Mon, Sep 05, 2016 at 07:57:51AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 25, 2016 at 04:31:07PM -0700, Christoph Hellwig wrote:
> > Originally-from: Christoph Hellwig <hch@xxxxxx>
> 
> This should be a
> 
> From: Christoph Hellwig <hch@xxxxxx>
> 
> so that git picks up authorship information correctly.
> 
> > XXX: might want a bigger name, and possible a better implementation
> > that doesn't require two lookups in the radix tree.
> 
> And these need to be looked into.  I can take a stab at it, but I need
> to get a few other things off my plate first.

Yeah.  It works well enough for unsharing blocks, if inefficiently.

Not sure what "a bigger name" means, though.  I tried feeding the
function prototype through figlet but gcc didn't like that. ;)

--D

<Prev in Thread] Current Thread [Next in Thread>