xfs
[Top] [All Lists]

Re: [PATCH 34/71] xfs: support bmapping delalloc extents in the CoW fork

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 34/71] xfs: support bmapping delalloc extents in the CoW fork
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Tue, 6 Sep 2016 09:34:13 -0700
Cc: david@xxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160906152553.GA9760@xxxxxxxxxxxxx>
References: <147216791538.867.12413509832420924168.stgit@xxxxxxxxxxxxxxxx> <147216814006.867.6404376654574855233.stgit@xxxxxxxxxxxxxxxx> <20160906152553.GA9760@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Tue, Sep 06, 2016 at 08:25:53AM -0700, Christoph Hellwig wrote:
> FYI, this has some major conflicts with the iomap updates - we'll need
> to know from Dave which one should go in first.

While we're combining patches, I think it makes sense to modify
_iomap_write_allocate so that when it's converting a data fork
delalloc reservation into a real extent that it should look for an
adjacent (file offset-wise) real extent in the CoW fork and feed that
to the allocator in the hopes of allocating all the blocks in the same
part of the disk.  Or better yet as one big(ger) extent record.

--D

<Prev in Thread] Current Thread [Next in Thread>