Re: [PATCH] xfsprogs: don't populate fs table with foreign fs paths unless foreign_allowed

["Bill O'Donnell" <billodo@xxxxxxxxxx>]

On Tue, Aug 30, 2016 at 09:40:44AM +1000, Dave Chinner wrote:
> On Mon, Aug 29, 2016 at 06:26:15PM -0500, Bill O'Donnell wrote:
> > On Tue, Aug 30, 2016 at 09:12:06AM +1000, Dave Chinner wrote:
> > > On Mon, Aug 29, 2016 at 08:40:12AM -0500, Bill O'Donnell wrote:
> > > > Commits b20b6c2 and 29647c8 modified xfs_quota for use on
> > > > non-XFS filesystems. One modification in fs_initialise_mounts
> > > > (paths.c) resulted in an xfstest fail (xfs/261), due to foreign
> > > > fs paths entering the fs table.
> > > 
> > > What's the failure? I'm not seeing it here on any of my test
> > > machines...
> > 
> > On my box, there are a few ext4 mounts, and test xfs/261 
> > populates the fs table with those paths.
> 
> I have ext2 and ext3 mounts on these machines as well, and they
> don't throw any errors.
> 
> > So when xfs_quota commands
> > in 261 are executed, a "foreign filesystem" message is thrown.
> 
> What is the output that is causing the failure? When someone
> asks you to describe the error that is occurring, please quote the
> /exact error/ that is occurring - describing it via paraphrasing
> does not tell anything useful about the error as I cannot correlate
> that description to the code that is throwing it.

Ahh, ok, I'm sorry about that.
[root@dell-pesc440-01 xfstests-dev]# ./check -d tests/xfs/261
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 dell-pesc440-01 4.7.0-rc108052016bill02+
MKFS_OPTIONS  -- -f -bsize=4096 /dev/mapper/fedora_dell--pesc440--01-csdf
MOUNT_OPTIONS -- -o context=system_u:object_r:nfs_t:s0 
/dev/mapper/fedora_dell--pesc440--01-csdf /mnt/scratch

xfs/261 2s ...QA output created by 261
Silence is golden.
print command is for XFS filesystems only
print command is for XFS filesystems only
print command is for XFS filesystems only
print command is for XFS filesystems only
print command is for XFS filesystems only
print command is for XFS filesystems only
print command is for XFS filesystems only
print command is for XFS filesystems only
 - output mismatch (see /root/xfstests-dev/results//xfs/261.out.bad)
    --- tests/xfs/261.out       2016-08-09 15:45:47.471465224 -0400
    +++ /root/xfstests-dev/results//xfs/261.out.bad     2016-08-29 
19:45:58.166965834 -0400
    @@ -1,2 +1,10 @@
     QA output created by 261
     Silence is golden.
    +print command is for XFS filesystems only
    +print command is for XFS filesystems only
    +print command is for XFS filesystems only
    +print command is for XFS filesystems only
    +print command is for XFS filesystems only
    ...
    (Run 'diff -u tests/xfs/261.out 
/root/xfstests-dev/results//xfs/261.out.bad'  to see the entire diff)
Ran: xfs/261
Failures: xfs/261
Failed 1 of 1 tests



> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx