xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: don't populate fs table with foreign fs paths unle

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: don't populate fs table with foreign fs paths unless foreign_allowed
From: "Bill O'Donnell" <billodo@xxxxxxxxxx>
Date: Mon, 29 Aug 2016 18:26:15 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160829231205.GO19025@dastard>
References: <1472478012-23627-1-git-send-email-billodo@xxxxxxxxxx> <20160829231205.GO19025@dastard>
User-agent: Mutt/1.7.0 (2016-08-17)
On Tue, Aug 30, 2016 at 09:12:06AM +1000, Dave Chinner wrote:
> On Mon, Aug 29, 2016 at 08:40:12AM -0500, Bill O'Donnell wrote:
> > Commits b20b6c2 and 29647c8 modified xfs_quota for use on
> > non-XFS filesystems. One modification in fs_initialise_mounts
> > (paths.c) resulted in an xfstest fail (xfs/261), due to foreign
> > fs paths entering the fs table.
> 
> What's the failure? I'm not seeing it here on any of my test
> machines...

On my box, there are a few ext4 mounts, and test xfs/261 
populates the fs table with those paths. So when xfs_quota commands
in 261 are executed, a "foreign filesystem" message is thrown.
My first notion was to add a -f to the xfs_quota command in 261,
but then I decided it was better to change the xfsprogs code back
to the old behavior.

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>