xfs
[Top] [All Lists]

Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option

To: Zorro Lang <zlang@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_quota: fix missing break after foreign_allowed option
From: "Bill O'Donnell" <billodo@xxxxxxxxxx>
Date: Fri, 26 Aug 2016 08:36:26 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1472200206-15728-1-git-send-email-zlang@xxxxxxxxxx>
References: <1472200206-15728-1-git-send-email-zlang@xxxxxxxxxx>
User-agent: Mutt/1.6.2 (2016-07-01)
On Fri, Aug 26, 2016 at 04:30:06PM +0800, Zorro Lang wrote:
> New quota "-f" has been brought in by:
> 
>   29647c8 xfs_quota: add capabilities for use on non-XFS filesystems
> 
> But Coverity Scan find a missing break in quota/init.c: init()
> function.
> 
> Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>

Sorry about that.
Thanks for the patch, Zorro.

Reviewed-by: Bill O'Donnell <billodo@xxxxxxxxxx>

> ---
>  quota/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/quota/init.c b/quota/init.c
> index 44be322..2c18c8b 100644
> --- a/quota/init.c
> +++ b/quota/init.c
> @@ -153,6 +153,7 @@ init(
>                       break;
>               case 'f':
>                       foreign_allowed = true;
> +                     break;
>               case 't':
>                       mtab_file = optarg;
>                       break;
> -- 
> 2.7.4
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>