| To: | david@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, darrick.wong@xxxxxxxxxx |
|---|---|
| Subject: | [PATCH 1/6] vfs: fix return type of ioctl_file_dedupe_range |
| From: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
| Date: | Thu, 25 Aug 2016 16:30:47 -0700 |
| Cc: | linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <147216784041.525.7722906502172299465.stgit@xxxxxxxxxxxxxxxx> |
| References: | <147216784041.525.7722906502172299465.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | StGit/0.17.1-dirty |
All the VFS functions in the dedupe ioctl path return int status, so
the ioctl handler ought to as well.
Found by Coverity, CID 1350952.
Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
fs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index 0f56deb..26aba09 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -568,7 +568,7 @@ static int ioctl_fsthaw(struct file *filp)
return thaw_super(sb);
}
-static long ioctl_file_dedupe_range(struct file *file, void __user *arg)
+static int ioctl_file_dedupe_range(struct file *file, void __user *arg)
{
struct file_dedupe_range __user *argp = arg;
struct file_dedupe_range *same = NULL;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH v8 0/6] vfs: help support reflink for XFS, Darrick J. Wong |
|---|---|
| Next by Date: | [PATCH 2/6] vfs: cap dedupe request structure size at PAGE_SIZE, Darrick J. Wong |
| Previous by Thread: | [PATCH v8 0/6] vfs: help support reflink for XFS, Darrick J. Wong |
| Next by Thread: | [PATCH 2/6] vfs: cap dedupe request structure size at PAGE_SIZE, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |