| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/7] libxcmd: fix mount option parsing to find rt/log devices |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 25 Aug 2016 02:12:12 -0700 |
| Cc: | david@xxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <147200548998.15538.11330546457799095768.stgit@xxxxxxxxxxxxxxxx> |
| References: | <147200546481.15538.12724000421579716885.stgit@xxxxxxxxxxxxxxxx> <147200548998.15538.11330546457799095768.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.6.1 (2016-04-27) |
On Tue, Aug 23, 2016 at 07:24:50PM -0700, Darrick J. Wong wrote:
> It turns out that glibc's hasmntopt implementation returns NULL
> if the opt parameter ends with an equals ('='). Therefore, we
> cannot directly search for the option 'rtdev='; we must instead
> have hasmntopt look for 'rtdev' and look for the trailing equals
> sign ourselves. This fixes xfs_info's reporting of external
> log and realtime device paths, and xfs_scrub will need it for
> data block scrubbing of realtime extents.
Looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| Previous by Date: | Re: [PATCH 3/7] xfs: simple btree query range should look right if LE lookup fails, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 5/7] misc: fix Coverity errors, Christoph Hellwig |
| Previous by Thread: | [PATCH 4/7] libxcmd: fix mount option parsing to find rt/log devices, Darrick J. Wong |
| Next by Thread: | [PATCH 5/7] misc: fix Coverity errors, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |