xfs
[Top] [All Lists]

Re: [PATCHv2 xfsprogs 00/14] Convert from off64_t to off_t

To: Felix Janda <felix.janda@xxxxxxxxx>
Subject: Re: [PATCHv2 xfsprogs 00/14] Convert from off64_t to off_t
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 25 Aug 2016 01:04:02 -0700
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160824204746.GA25162@nyan>
References: <cover.1471107858.git.felix.janda@xxxxxxxxx> <20160824011911.GA19025@dastard> <20160824204746.GA25162@nyan>
User-agent: Mutt/1.6.1 (2016-04-27)
On Wed, Aug 24, 2016 at 10:47:46PM +0200, Felix Janda wrote:
> > screws up xfstests because it changes all the error messages
> > that are output to stderr and captured by the test harness.
> > There are quite a few tests that this causes failures for,
> > and because it's stderr, it's not as simple as just adding a new
> > filter to do 'sed -e "s/^\(.*\)64\(: .*$\)/\1\2/"' on stderr.
> 
> Thanks for testing!
> 
> I can rework the patches to leave stderr unchanged. I guess that this
> is preferable as opposed to updating the output expected by xfstests
> since xfstests should be usable with both old and new xfsprogs.

I would prefer to change the output if we can find a good way to
filter it.  I suspect the issues are things like perror lines
which would look odd if we leave the 64 back in.

<Prev in Thread] Current Thread [Next in Thread>