| To: | Peter Zijlstra <peterz@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Sat, 20 Aug 2016 08:37:23 +0200 |
| Cc: | Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160819132736.GH10121@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <1470935423-12329-1-git-send-email-hch@xxxxxx> <20160811215444.GY30192@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20160818173707.GA1240@xxxxxx> <20160819132736.GH10121@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Fri, Aug 19, 2016 at 03:27:36PM +0200, Peter Zijlstra wrote: > Hurm, if you're going to directly use that maybe we should pick a better > name ;-) Fine with that. > Also, be sure to check the debug_locks variable, if that's cleared the > result of _lockdep_is_held() isn't reliable -- we stop tracking lock > state when there's an error. I already do. But I'm wondering if we can't simply move the debug_locks check into lockdep_is_held? It's already used directly in a few places, and that would also solve the whole naming issue. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | IRQ Lock Inversion dependency detected?, Andrew Ryder |
|---|---|
| Next by Date: | Re: IRQ Lock Inversion dependency detected?, Dave Chinner |
| Previous by Thread: | Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead, Peter Zijlstra |
| Next by Thread: | Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead, Peter Zijlstra |
| Indexes: | [Date] [Thread] [Top] [All Lists] |