xfs
[Top] [All Lists]

[PATCHv2 xfsprogs 07/14] replace pread64/pwrite64 by equivalent pread/pw

To: xfs@xxxxxxxxxxx
Subject: [PATCHv2 xfsprogs 07/14] replace pread64/pwrite64 by equivalent pread/pwrite
From: Felix Janda <felix.janda@xxxxxxxxx>
Date: Sat, 6 Aug 2016 12:45:52 +0200
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <cover.1471107858.git.felix.janda@xxxxxxxxx>
References: <cover.1471107858.git.felix.janda@xxxxxxxxx>
Resent-date: Sat, 13 Aug 2016 19:24:42 +0200
Resent-from: Felix Janda <felix.janda@xxxxxxxxx>
Resent-message-id: <20160813172442.GE3858@nyan>
Resent-to: xfs@xxxxxxxxxxx
Signed-off-by: Felix Janda <felix.janda@xxxxxxxxx>
---
 copy/xfs_copy.c           |  2 +-
 include/darwin.h          |  2 --
 include/freebsd.h         |  2 --
 io/pread.c                | 10 +++++-----
 io/pwrite.c               | 10 +++++-----
 libxfs/rdwr.c             |  8 ++++----
 mdrestore/xfs_mdrestore.c |  4 ++--
 mkfs/xfs_mkfs.c           |  2 +-
 po/de.po                  |  4 ++--
 po/pl.po                  |  8 ++++----
 repair/prefetch.c         |  2 +-
 11 files changed, 25 insertions(+), 29 deletions(-)

diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
index cc5207d..816ab29 100644
--- a/copy/xfs_copy.c
+++ b/copy/xfs_copy.c
@@ -860,7 +860,7 @@ main(int argc, char **argv)
 
                        off = mp->m_sb.sb_dblocks * source_blocksize;
                        off -= sizeof(lb);
-                       if (pwrite64(target[i].fd, lb, sizeof(lb), off) < 0)  {
+                       if (pwrite(target[i].fd, lb, sizeof(lb), off) < 0)  {
                                do_log(_("%s:  failed to write last block\n"),
                                        progname);
                                do_log(_("\tIs target \"%s\" too small?\n"),
diff --git a/include/darwin.h b/include/darwin.h
index 850d733..fb13915 100644
--- a/include/darwin.h
+++ b/include/darwin.h
@@ -141,8 +141,6 @@ typedef u_int64_t   xfs_ino_t;
 typedef u_int32_t      xfs_dev_t;
 typedef int64_t                xfs_daddr_t;
 
-#define pread64                pread
-#define pwrite64       pwrite
 #define fdatasync      fsync
 #define memalign(a,sz) valloc(sz)
 
diff --git a/include/freebsd.h b/include/freebsd.h
index 784e287..df924ef 100644
--- a/include/freebsd.h
+++ b/include/freebsd.h
@@ -34,8 +34,6 @@
 #define __LITTLE_ENDIAN        LITTLE_ENDIAN
 
 /* FreeBSD file API is 64-bit aware */
-#define pwrite64       pwrite
-#define pread64                pread
 #define fdatasync      fsync
 #define memalign(a,sz) valloc(sz)
 
diff --git a/io/pread.c b/io/pread.c
index cafead0..3395503 100644
--- a/io/pread.c
+++ b/io/pread.c
@@ -214,7 +214,7 @@ do_pread(
        ssize_t         buffer_size)
 {
        if (!vectors)
-               return pread64(fd, buffer, min(count, buffer_size), offset);
+               return pread(fd, buffer, min(count, buffer_size), offset);
 
        return do_preadv(fd, offset, count, buffer_size);
 }
@@ -254,7 +254,7 @@ read_random(
                if (bytes == 0)
                        break;
                if (bytes < 0) {
-                       perror("pread64");
+                       perror("pread");
                        return -1;
                }
                ops++;
@@ -296,7 +296,7 @@ read_backward(
                if (bytes == 0)
                        return ops;
                if (bytes < 0) {
-                       perror("pread64");
+                       perror("pread");
                        return -1;
                }
                ops++;
@@ -314,7 +314,7 @@ read_backward(
                if (bytes == 0)
                        break;
                if (bytes < 0) {
-                       perror("pread64");
+                       perror("pread");
                        return -1;
                }
                ops++;
@@ -345,7 +345,7 @@ read_forward(
                if (bytes == 0)
                        break;
                if (bytes < 0) {
-                       perror("pread64");
+                       perror("pread");
                        return -1;
                }
                ops++;
diff --git a/io/pwrite.c b/io/pwrite.c
index 67631ce..7c0bb7f 100644
--- a/io/pwrite.c
+++ b/io/pwrite.c
@@ -101,7 +101,7 @@ do_pwrite(
        ssize_t         buffer_size)
 {
        if (!vectors)
-               return pwrite64(fd, buffer, min(count, buffer_size), offset);
+               return pwrite(fd, buffer, min(count, buffer_size), offset);
 
        return do_pwritev(fd, offset, count, buffer_size);
 }
@@ -137,7 +137,7 @@ write_random(
                if (bytes == 0)
                        break;
                if (bytes < 0) {
-                       perror("pwrite64");
+                       perror("pwrite");
                        return -1;
                }
                ops++;
@@ -175,7 +175,7 @@ write_backward(
                if (bytes == 0)
                        return ops;
                if (bytes < 0) {
-                       perror("pwrite64");
+                       perror("pwrite");
                        return -1;
                }
                ops++;
@@ -193,7 +193,7 @@ write_backward(
                if (bytes == 0)
                        break;
                if (bytes < 0) {
-                       perror("pwrite64");
+                       perror("pwrite");
                        return -1;
                }
                ops++;
@@ -228,7 +228,7 @@ write_buffer(
                if (bytes == 0)
                        break;
                if (bytes < 0) {
-                       perror("pwrite64");
+                       perror("pwrite");
                        return -1;
                }
                ops++;
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index cb74b3c..8e9d86a 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -915,7 +915,7 @@ __read_buf(int fd, void *buf, int len, off64_t offset, int 
flags)
 {
        int     sts;
 
-       sts = pread64(fd, buf, len, offset);
+       sts = pread(fd, buf, len, offset);
        if (sts < 0) {
                int error = errno;
                fprintf(stderr, _("%s: read failed: %s\n"),
@@ -1083,16 +1083,16 @@ __write_buf(int fd, void *buf, int len, off64_t offset, 
int flags)
 {
        int     sts;
 
-       sts = pwrite64(fd, buf, len, offset);
+       sts = pwrite(fd, buf, len, offset);
        if (sts < 0) {
                int error = errno;
-               fprintf(stderr, _("%s: pwrite64 failed: %s\n"),
+               fprintf(stderr, _("%s: pwrite failed: %s\n"),
                        progname, strerror(error));
                if (flags & LIBXFS_B_EXIT)
                        exit(1);
                return -error;
        } else if (sts != len) {
-               fprintf(stderr, _("%s: error - pwrite64 only %d of %d bytes\n"),
+               fprintf(stderr, _("%s: error - pwrite only %d of %d bytes\n"),
                        progname, sts, len);
                if (flags & LIBXFS_B_EXIT)
                        exit(1);
diff --git a/mdrestore/xfs_mdrestore.c b/mdrestore/xfs_mdrestore.c
index 1540dcd..0d399f1 100644
--- a/mdrestore/xfs_mdrestore.c
+++ b/mdrestore/xfs_mdrestore.c
@@ -134,7 +134,7 @@ perform_restore(
                off64_t         off;
 
                off = sb.sb_dblocks * sb.sb_blocksize - sizeof(lb);
-               if (pwrite64(dst_fd, lb, sizeof(lb), off) < 0)
+               if (pwrite(dst_fd, lb, sizeof(lb), off) < 0)
                        fatal("failed to write last block, is target too "
                                "small? (error: %s)\n", strerror(errno));
        }
@@ -146,7 +146,7 @@ perform_restore(
                        print_progress("%lld MB read", bytes_read >> 20);
 
                for (cur_index = 0; cur_index < mb_count; cur_index++) {
-                       if (pwrite64(dst_fd, &block_buffer[cur_index <<
+                       if (pwrite(dst_fd, &block_buffer[cur_index <<
                                        tmb.mb_blocklog], block_size,
                                        be64_to_cpu(block_index[cur_index]) <<
                                                BBSHIFT) < 0)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 5d5fcb7..e038d48 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -1111,7 +1111,7 @@ zero_old_xfs_structures(
        off = 0;
        for (i = 1; i < sb.sb_agcount; i++)  {
                off += sb.sb_agblocks;
-               if (pwrite64(xi->dfd, buf, new_sb->sb_sectsize,
+               if (pwrite(xi->dfd, buf, new_sb->sb_sectsize,
                                        off << sb.sb_blocklog) == -1)
                        break;
        }
diff --git a/po/de.po b/po/de.po
index ff1930e..fab2667 100644
--- a/po/de.po
+++ b/po/de.po
@@ -5893,8 +5893,8 @@ msgstr "%s: lesen fehlgeschlagen: %s\n"
 
 #: .././libxfs/rdwr.c:502
 #, c-format
-msgid "%s: pwrite64 failed: %s\n"
-msgstr "%s: pwrite64 fehlgeschlagen: %s\n"
+msgid "%s: pwrite failed: %s\n"
+msgstr "%s: pwrite fehlgeschlagen: %s\n"
 
 #: .././libxfs/rdwr.c:509
 #, c-format
diff --git a/po/pl.po b/po/pl.po
index 33a9d81..49209f3 100644
--- a/po/pl.po
+++ b/po/pl.po
@@ -5940,13 +5940,13 @@ msgstr "%s: bÅ?Ä?d - odczytano tylko %d z %d bajtów\n"
 
 #: .././libxfs/rdwr.c:878
 #, c-format
-msgid "%s: pwrite64 failed: %s\n"
-msgstr "%s: pwrite64 nie powiodÅ?o siÄ?: %s\n"
+msgid "%s: pwrite failed: %s\n"
+msgstr "%s: pwrite nie powiodÅ?o siÄ?: %s\n"
 
 #: .././libxfs/rdwr.c:884
 #, c-format
-msgid "%s: error - pwrite64 only %d of %d bytes\n"
-msgstr "%s: bÅ?Ä?d - wykonano pwrite64 tylko %d z %d bajtów\n"
+msgid "%s: error - pwrite only %d of %d bytes\n"
+msgstr "%s: bÅ?Ä?d - wykonano pwrite tylko %d z %d bajtów\n"
 
 #: .././libxfs/rdwr.c:920
 #, c-format
diff --git a/repair/prefetch.c b/repair/prefetch.c
index b4f20d9..175594c 100644
--- a/repair/prefetch.c
+++ b/repair/prefetch.c
@@ -565,7 +565,7 @@ pf_batch_read(
                /*
                 * now read the data and put into the xfs_but_t's
                 */
-               len = pread64(mp_fd, buf, (int)(last_off - first_off), 
first_off);
+               len = pread(mp_fd, buf, (int)(last_off - first_off), first_off);
 
                /*
                 * Check the last buffer on the list to see if we need to
-- 
2.7.3

<Prev in Thread] Current Thread [Next in Thread>