xfs
[Top] [All Lists]

Re: [PATCH xfsprogs] libxcmd: link against used libs

To: Mike Frysinger <vapier@xxxxxxxxxx>
Subject: Re: [PATCH xfsprogs] libxcmd: link against used libs
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 10 Aug 2016 07:49:10 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160809144343.2228-1-vapier@xxxxxxxxxx>
References: <20160809144343.2228-1-vapier@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Aug 09, 2016 at 10:43:43PM +0800, Mike Frysinger wrote:
> Since this lib uses symbols from libxfs (platform_findsizes) and many
> symbols from libblkid, link against both.  Otherwise, the resulting
> shared lib has missing symbols which makes linking against annoying.

libxcmd is an internal library, linked directly into the xfsprogs
binaries. It is never shipped or used outside xfsprogs, so what is
trying to use libxcmd as a shared library that doesn't also link
against libblkid or libxfs?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>