Re: [PATCH 4/5] fs: Give dentry to inode_change

xfs

Re: [PATCH 4/5] fs: Give dentry to inode_change_ok() instead of inode

To:	Jan Kara <jack@xxxxxxx>
Subject:	Re: [PATCH 4/5] fs: Give dentry to inode_change_ok() instead of inode
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 9 Aug 2016 01:28:28 -0700
Cc:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, xfs@xxxxxxxxxxx, "Yan, Zheng" <zyan@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Ilya Dryomov <idryomov@xxxxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1470223689-17783-5-git-send-email-jack@xxxxxxx>
References:	<1470223689-17783-1-git-send-email-jack@xxxxxxx> <1470223689-17783-5-git-send-email-jack@xxxxxxx>
User-agent:	Mutt/1.6.1 (2016-04-27)

On Wed, Aug 03, 2016 at 01:28:08PM +0200, Jan Kara wrote:
> inode_change_ok() will be resposible for clearing capabilities and IMA
> extended attributes and as such will need dentry. Give it as an argument
> to inode_change_ok() instead of an inode. Also rename inode_change_ok()
> to setattr_prepare() to better relect that it does also some
> modifications in addition to checks.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/5 v2] fs: Avoid premature clearing of file capabilities, Jan Kara [PATCH 5/5] fs: Avoid premature clearing of capabilities, Jan Kara Re: [PATCH 5/5] fs: Avoid premature clearing of capabilities, Christoph Hellwig [PATCH 4/5] fs: Give dentry to inode_change_ok() instead of inode, Jan Kara Re: [PATCH 4/5] fs: Give dentry to inode_change_ok() instead of inode, Christoph Hellwig <= [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Jan Kara Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Christoph Hellwig Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Jan Kara Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Christoph Hellwig [PATCH 2/5] ceph: Propagate dentry down to inode_change_ok(), Jan Kara [PATCH 3/5] fuse: Propagate dentry down to inode_change_ok(), Jan Kara

Previous by Date:	Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Christoph Hellwig
Next by Date:	Re: [PATCH 5/5] fs: Avoid premature clearing of capabilities, Christoph Hellwig
Previous by Thread:	[PATCH 4/5] fs: Give dentry to inode_change_ok() instead of inode, Jan Kara
Next by Thread:	[PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Jan Kara
Indexes:	[Date] [Thread] [Top] [All Lists]