| To: | Jan Kara <jack@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 9 Aug 2016 01:27:56 -0700 |
| Cc: | Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, xfs@xxxxxxxxxxx, "Yan, Zheng" <zyan@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Ilya Dryomov <idryomov@xxxxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1470223689-17783-2-git-send-email-jack@xxxxxxx> |
| References: | <1470223689-17783-1-git-send-email-jack@xxxxxxx> <1470223689-17783-2-git-send-email-jack@xxxxxxx> |
| User-agent: | Mutt/1.6.1 (2016-04-27) |
> +static int > +xfs_vn_change_ok( > + struct dentry *dentry, > + struct iattr *iattr) Please don't use the _vn prefix for something that's not an actual inode operation (and we should do a mess rename to _iop one day as well.) > +int > +xfs_vn_setattr_nonsize( > + struct dentry *dentry, > + struct iattr *iattr) Same here. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: Document error handling behavior, Carlos Maiolino |
|---|---|
| Next by Date: | Re: [PATCH 4/5] fs: Give dentry to inode_change_ok() instead of inode, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Jan Kara |
| Next by Thread: | Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok(), Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |