xfs
[Top] [All Lists]

Re: [PATCH v7 00/47] xfs: add reverse mapping support

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v7 00/47] xfs: add reverse mapping support
From: Artem Bityutskiy <dedekind1@xxxxxxxxx>
Date: Fri, 05 Aug 2016 14:57:16 +0300
Cc: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160805104950.GF16044@dastard>
References: <146907695530.25461.3225785294902719773.stgit@xxxxxxxxxxxxxxxx> <20160803194536.GJ5316@xxxxxxxxxxxxx> <20160803205520.GQ8590@xxxxxxxxxxxxxxxx> <20160804005843.GJ8593@xxxxxxxxxxxxxxxx> <20160804021852.GK5316@xxxxxxxxxxxxx> <20160804154845.GV8590@xxxxxxxxxxxxxxxx> <20160804235015.GC16044@dastard> <1470380474.2311.71.camel@xxxxxxxxx> <20160805104950.GF16044@dastard>
Reply-to: dedekind1@xxxxxxxxx
On Fri, 2016-08-05 at 20:49 +1000, Dave Chinner wrote:
> On Fri, Aug 05, 2016 at 10:01:14AM +0300, Artem Bityutskiy wrote:
> > 
> > On Fri, 2016-08-05 at 09:50 +1000, Dave Chinner wrote:
> > > 
> > > I'd much prefer that fiemap gives exact information about shared
> > > extents. FIEMAP is a diagnostic tool and as such we need it to
> > > accurately reflect the exact extent map of the inode being
> > > queried
> > > so we aren't mislead about the layout of the file during trouble
> > > shooting.
> > 
> > Hi Dave, you are right, and here is a side note: Âwe were using
> > FIEMAP
> > for optimizing image deployment in production, so it is a
> > diagnostic
> > tool and more.
> 
> Yay, data corruption ahoy!
> 
> Hasn't /anyone/ listened to the repeated statements from fs
> developers that FIEMAP is not a safe method of optimising data
> copying?

Yes, which is kind of sad from the user's perspective. We had issues
with XFS, not ext4, and tweaking preallocation helped.

<Prev in Thread] Current Thread [Next in Thread>