xfs
[Top] [All Lists]

Re: [PATCH 37/45] drivers: use req op accessor

To: Shaun Tancheff <shaun.tancheff@xxxxxxxxxxx>
Subject: Re: [PATCH 37/45] drivers: use req op accessor
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 4 Aug 2016 08:46:22 -0700
Cc: Mike Christie <mchristi@xxxxxxxxxx>, philipp.reisner@xxxxxxxxxx, dm-devel@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, linux-ext4 <linux-ext4@xxxxxxxxxxxxxxx>, konrad.wilk@xxxxxxxxxx, XFS Developers <xfs@xxxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, osd-dev@xxxxxxxxxxxx, Ross Zwisler <zwisler@xxxxxxxxx>, Jens Axboe <axboe@xxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, lars.ellenberg@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAJVOszAd9Eu88P2=QoNVArd0jwDH7KRe=OB82tCNMpjfv9B4KA@xxxxxxxxxxxxxx>
References: <1465155145-10812-1-git-send-email-mchristi@xxxxxxxxxx> <1465155145-10812-38-git-send-email-mchristi@xxxxxxxxxx> <CAOxpaSUMsgfTYsL0bL6VCnwxz7bpgpKO-ZfC5J8dFG9PN-hzvg@xxxxxxxxxxxxxx> <87fbe31f-27b3-ff7a-e381-34fc1aad337e@xxxxxxxxxx> <CAJVOszAd9Eu88P2=QoNVArd0jwDH7KRe=OB82tCNMpjfv9B4KA@xxxxxxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
On Wed, Aug 03, 2016 at 07:30:29PM -0500, Shaun Tancheff wrote:
> I think the translation in loop.c is suspicious here:
> 
>     "if use DIO && not (a flush_flag or discard_flag)"
> should translate to:
>     "if use DIO && not ((a flush_flag) || op == discard)"
> 
> But in the patch I read:
>     "if use DIO && ((not a flush_flag) || op == discard)
> 
> Which would have DIO && discards follow the AIO path?

Indeed.  Sorry for missing out on your patch, I just sent a fix
in reply to Dave's other report earlier which is pretty similar to
yours.

<Prev in Thread] Current Thread [Next in Thread>