xfs
[Top] [All Lists]

[PATCH 0/5 v2] fs: Avoid premature clearing of file capabilities

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: [PATCH 0/5 v2] fs: Avoid premature clearing of file capabilities
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 3 Aug 2016 13:28:04 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, "Yan, Zheng" <zyan@xxxxxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx, Miklos Szeredi <miklos@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Hello,

this patch series is my attempt to fix an issue when user can clear capabilites
of arbitrary file he can look up for example by running chown on it (this got
assigned CVE-2015-1350). The problem is that we call security_inode_killpriv()
before checking permissions in inode_change_ok(). This patch set moves that
call into inode_change_ok() after permissions are checked - the only trouble is
that we need to give dentry instead of inode there and that is not completely
trivial in some cases - I'm still missing a review from Ceph people to verify I
didn't miss anything.

Anyway, I guess the changes are fine for merging. Al, you please merge the
patches? Thanks!

Changes since v1:
* Added acks for XFS and FUSE patches

                                                                Honza

<Prev in Thread] Current Thread [Next in Thread>