xfs
[Top] [All Lists]

Re: [PATCH v2 RESEND] fs: return EPERM on immutable inode

To: Eryu Guan <guaneryu@xxxxxxxxx>
Subject: Re: [PATCH v2 RESEND] fs: return EPERM on immutable inode
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 2 Aug 2016 05:28:08 -0700
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, open list <linux-kernel@xxxxxxxxxxxxxxx>, "supporter:XFS FILESYSTEM" <xfs@xxxxxxxxxxx>, "open list:GFS2 FILE SYSTEM" <cluster-devel@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Bob Peterson <rpeterso@xxxxxxxxxx>, Steven Whitehouse <swhiteho@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1470139108-13115-1-git-send-email-guaneryu@xxxxxxxxx>
References: <1470139108-13115-1-git-send-email-guaneryu@xxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
On Tue, Aug 02, 2016 at 07:58:28PM +0800, Eryu Guan wrote:
> In most cases, EPERM is returned on immutable inode, and there're only a
> few places returning EACCES. I noticed this when running LTP on
> overlayfs, setxattr03 failed due to unexpected EACCES on immutable
> inode.
> 
> So converting all EACCES to EPERM on immutable inode.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Although maybe you'll have to split this into one patch per subsystems,
as otherwise no maintainer might be enticed to pick it up.

<Prev in Thread] Current Thread [Next in Thread>