xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] xfs_quota: fall back silently if XFS_GETNEXTQUOTA fails

from [Christoph Hellwig] [Permanent Link][Original]
To: Zorro Lang <zlang@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_quota: fall back silently if XFS_GETNEXTQUOTA fails
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 2 Aug 2016 05:27:21 -0700
Cc: xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1470120540-15135-1-git-send-email-zlang@xxxxxxxxxx>
References: <1470120540-15135-1-git-send-email-zlang@xxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27) 
On Tue, Aug 02, 2016 at 02:49:00PM +0800, Zorro Lang wrote:
> After XFS_GETNEXTQUOTA feature has been merged into linux kernel and
> xfsprogs, xfs_quota use Q_XGETNEXTQUOTA for report and dump, and
> fall back to old XFS_GETQUOTA ioctl if XFS_GETNEXTQUOTA fails.
> 
> But when XFS_GETNEXTQUOTA fails, xfs_quota print a warning as
> "XFS_GETQUOTA: Invalid argument". That's due to kernel can't
> recognize XFS_GETNEXTQUOTA ioctl and return EINVAL. At this time,
> the warning is helpless, xfs_quota just need to fall back.

We'd still want to report other errors, right?
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] xfs: in _attrlist_by_handle, copy the cursor back to userspace, Christoph Hellwig
Next by Date:  Re: [PATCH v2 RESEND] fs: return EPERM on immutable inode, Christoph Hellwig
Previous by Thread:  [PATCH] xfs_quota: fall back silently if XFS_GETNEXTQUOTA fails, Zorro Lang
Next by Thread:  Re: [PATCH] xfs_quota: fall back silently if XFS_GETNEXTQUOTA fails, Zorro Lang
Indexes:  [Date] [Thread] [Top] [All Lists]