Re: [PATCH] vfs: fix return type of ioctl_file_dedupe

xfs

Re: [PATCH] vfs: fix return type of ioctl_file_dedupe_range

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [PATCH] vfs: fix return type of ioctl_file_dedupe_range
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 2 Aug 2016 05:24:14 -0700
Cc:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20160801171339.GB8590@xxxxxxxxxxxxxxxx>
References:	<20160801171339.GB8590@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.6.1 (2016-04-27)

On Mon, Aug 01, 2016 at 10:13:39AM -0700, Darrick J. Wong wrote:
> All the VFS functions in the dedupe ioctl path return int status, so
> the ioctl handler ought to as well.
> 
> Found by Coverity, CID 1350952.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] vfs: fix return type of ioctl_file_dedupe_range, Darrick J. Wong Re: [PATCH] vfs: fix return type of ioctl_file_dedupe_range, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 06/17] xfs: run xfs_repair at the end of each test, Christoph Hellwig
Next by Date:	Re: [PATCH] xfs_io: Update man page for copy_range command, Christoph Hellwig
Previous by Thread:	[PATCH] vfs: fix return type of ioctl_file_dedupe_range, Darrick J. Wong
Next by Thread:	[PATCH] xfs_io: Update man page for copy_range command, Anna Schumaker
Indexes:	[Date] [Thread] [Top] [All Lists]