xfs
[Top] [All Lists]

Re: [PATCH 11/47] xfs: move deferred operations into a separate file

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 11/47] xfs: move deferred operations into a separate file
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 1 Aug 2016 01:02:23 -0700
Cc: david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <146907703710.25461.16650495404061662831.stgit@xxxxxxxxxxxxxxxx>
References: <146907695530.25461.3225785294902719773.stgit@xxxxxxxxxxxxxxxx> <146907703710.25461.16650495404061662831.stgit@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
I looked over this again and I really don't see the use case of merging
it.  Yes, the freed extent, rmap and reflink code is fairly similar, but
there is all kinds of subtile differences that we need to paper over using
methods and flags.  I think we're better off not trying to share this
code and have a separate, but easily understandable implementation
for each btree.  At least for the traditional traditional freed extent
case the new code also is a lot less optimal than the previous version.

<Prev in Thread] Current Thread [Next in Thread>