Re: [PATCH 03/47] xfs: fix attr shortform structure alignment on cris

xfs

Re: [PATCH 03/47] xfs: fix attr shortform structure alignment on cris

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [PATCH 03/47] xfs: fix attr shortform structure alignment on cris
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sun, 31 Jul 2016 23:34:18 -0700
Cc:	david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<146907698036.25461.13007151908183013504.stgit@xxxxxxxxxxxxxxxx>
References:	<146907695530.25461.3225785294902719773.stgit@xxxxxxxxxxxxxxxx> <146907698036.25461.13007151908183013504.stgit@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.6.1 (2016-04-27)

On Wed, Jul 20, 2016 at 09:56:20PM -0700, Darrick J. Wong wrote:
> Apparently cris doesn't require structure stride to align with the
> largest type in the struct, so list[0] isn't at offset 4 like it is
> everywhere else.  Fix this... insofar as existing XFSes on cris are
> screwed.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Looks fine and should go in ASAP:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 03/47] xfs: fix attr shortform structure alignment on cris, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 02/47] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE, Christoph Hellwig
Next by Date:	Re: [PATCH 04/47] xfs: fix locking of the rt bitmap/summary inodes, Christoph Hellwig
Previous by Thread:	Re: [PATCH 02/47] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE, Christoph Hellwig
Next by Thread:	Re: [PATCH 04/47] xfs: fix locking of the rt bitmap/summary inodes, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]