Re: [PATCH 01/47] vfs: fix return type of ioctl_file_dedupe

xfs

Re: [PATCH 01/47] vfs: fix return type of ioctl_file_dedupe_range

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [PATCH 01/47] vfs: fix return type of ioctl_file_dedupe_range
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sun, 31 Jul 2016 23:33:22 -0700
Cc:	david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<146907696757.25461.13451944377009612990.stgit@xxxxxxxxxxxxxxxx>
References:	<146907695530.25461.3225785294902719773.stgit@xxxxxxxxxxxxxxxx> <146907696757.25461.13451944377009612990.stgit@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.6.1 (2016-04-27)

On Wed, Jul 20, 2016 at 09:56:07PM -0700, Darrick J. Wong wrote:
> All the VFS functions in the dedupe ioctl path return int status, so
> the ioctl handler ought to as well.
> 
> Found by Coverity, CID 1350952.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Nothing to do with rmap, or XFS for that matter.  Please send it
directly to Al.  Otherwise:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 01/47] vfs: fix return type of ioctl_file_dedupe_range, Christoph Hellwig <=

Previous by Date:	Re: xfs_icache.c:1298]: (style) Redundant condition, Christoph Hellwig
Next by Date:	Re: [PATCH 02/47] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE, Christoph Hellwig
Previous by Thread:	Re: xfs_icache.c:1298]: (style) Redundant condition, Christoph Hellwig
Next by Thread:	Re: [PATCH 02/47] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]