xfs_icache.c:1298]: (style) Redundant condition

To:	david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, dcb314@xxxxxxxxxxx
Subject:	xfs_icache.c:1298]: (style) Redundant condition
From:	David Binderman <linuxdev.baldrick@xxxxxxxxx>
Date:	Mon, 25 Jul 2016 16:13:28 +0100
Delivered-to:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=/glq95/EHhuaEw2AXZ33HOqWacnAtP8X2p2/5t8ZP9E=; b=twKPzspeITT4kKqoHz7WnDDx0hnhb5qa8LT/bw48uaaP37r9OG4soJJ4rYDcpxbnDj uLopCGMFTVBi5+F5TJ1zHx2kQvjZhDoyhAhIo1+XVyhUD4IUJtB1w2He1UCpY5UKoZ3F qcjdHMEqis+QhRcGHQFRfEaP3hoY+Yw1ecd032eM3lgqqjIrQ+kg18y862lYkNoixNp8 1dgJAPfaVe+oR6wOtPLgHRw3ibWQXmqmJlPVctuyUcQ+vfV6qYZthJHeUnOt3EpLLoby OzIH4BSi2acx3LXQjx85GJGRRx9zfRPvZJtpQOJufpYBqQVLe/u7dFxTCEXPyVyoIibK 2LTg==

Hello there,

linux-4.7/fs/xfs/xfs_icache.c:1298]: (style) Redundant condition:
eofb. '!eofb || (eofb && eofb.eof_scan_owner!=0)' is equivalent to
'!eofb || eofb.eof_scan_owner!=0'

Source code is

   ASSERT(!eofb || (eofb && eofb->eof_scan_owner != 0));

Maybe better code

   ASSERT(!eofb || (eofb->eof_scan_owner != 0));

Regards

David Binderman

<Prev in Thread]	Current Thread	[Next in Thread>
xfs_icache.c:1298]: (style) Redundant condition, David Binderman <=

Previous by Date:	[PATCH v24 22/22] ext4: Add richacl feature flag, Andreas Gruenbacher
Next by Date:	How to Enhance Emotional Intelligence at Work and Build Stronger Relationships, Emotional Intelligence at Work
Previous by Thread:	[PATCH v24 00/22] Richacls (Core and Ext4), Andreas Gruenbacher
Next by Thread:	How to Enhance Emotional Intelligence at Work and Build Stronger Relationships, Emotional Intelligence at Work
Indexes:	[Date] [Thread] [Top] [All Lists]