xfs
[Top] [All Lists]

Re: [PATCH] xfs: simplify the calculation of tpp at xfs_bmdr_to_bmbt

To: Hou Tao <houtao1@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: simplify the calculation of tpp at xfs_bmdr_to_bmbt
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 24 Jun 2016 16:38:05 +1000
Cc: xfs@xxxxxxxxxxx, miaoxie@xxxxxxxxxx, fangwei1@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1466746760-155962-1-git-send-email-houtao1@xxxxxxxxxx>
References: <1466746760-155962-1-git-send-email-houtao1@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jun 24, 2016 at 01:39:20PM +0800, Hou Tao wrote:
> remove the usage of rblocklen at xfs_bmdr_to_bmbt, and
> use be16_to_cpu(dblock->bb_numrecs) instead. It also
> reduces an extra calculation.

What problem does this fix, why does it need to be made and
how did you test it?

We have to be really careful about changing code that interacts with
the on-disk format, as any bugs we introduced will result in
filesystem corruption.  Hence you need to explain to the reviewers
why the change needs to be made to the reviewers...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>