xfs
[Top] [All Lists]

Re: [PATCH 008/145] libxfs: add more list operations

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 008/145] libxfs: add more list operations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 24 Jun 2016 10:40:22 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <146612709549.16048.6522744362673808871.stgit@xxxxxxxxxxxxxxxx>
References: <146612704434.16048.12932915166928562654.stgit@xxxxxxxxxxxxxxxx> <146612709549.16048.6522744362673808871.stgit@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 16, 2016 at 06:31:35PM -0700, Darrick J. Wong wrote:
> Add some list operations that the deferred rmap code requires.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

This has all come from the linux kernel, right? Can you tell me
which files it has come from so I can add it to the commit message?
Maybe it would be better to keep the list sorting code in it's own
file (e.g. libxfs/list_sort.c) just to keep a bit of separation
between the xfs code and code that is copied in from outside?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>