Re: [PATCH 2/3] block: require write_same and discard requests align to

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, "axboe@xxxxxxxxx" <axboe@xxxxxxxxx>
Subject:	Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size
From:	Bart Van Assche <bart.vanassche@xxxxxxxxx>
Date:	Mon, 20 Jun 2016 14:37:06 +0200
Cc:	"linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "tytso@xxxxxxx" <tytso@xxxxxxx>, "martin.petersen@xxxxxxxxxx" <martin.petersen@xxxxxxxxxx>, "snitzer@xxxxxxxxxx" <snitzer@xxxxxxxxxx>, "linux-api@xxxxxxxxxxxxxxx" <linux-api@xxxxxxxxxxxxxxx>, "bfoster@xxxxxxxxxx" <bfoster@xxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "hch@xxxxxxxxxxxxx" <hch@xxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=TDoG6awL+Gq2OpAUQhA4JrABhkPqxhGi6H8LhPUu/+4=; b=cz9jTecdpZq3jBCSPl3rqF1gLnS8nOcPi8tKYl3qbxvlWXzZ3C8rMO1wknuxwxh7JG WyYyDB3x26FXJuZeZ4kC0b+1q7ZQ/D7NKvgRwser1heONvfQeaHHu8LorO+Oz+AKph+M ojojjeOc+UQt57WsyDvF9NqF+iMFDbcME2Aib8aQD2uhij0GI7qUnyZCoZi/VOaaray/ /UblNe8tPludtkleNUsfk6JaWF+2ReaC9bTkkU6/5aKAojWvNCXjuDEqokRhZnuaQx+1 tndpexOjg6DvP7TKA/IK8c2YWprjaxJ1JFLyIlpLawcNlaHALO1mwd8n+fD9+yG+gsft fSWA==
In-reply-to:	<146612626092.12764.773833541076937471.stgit@xxxxxxxxxxxxxxxx>
References:	<146612624734.12764.4316680863289411106.stgit@xxxxxxxxxxxxxxxx> <146612626092.12764.773833541076937471.stgit@xxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 06/17/2016 03:19 AM, Darrick J. Wong wrote:

Make sure that the offset and length arguments that we're using to
construct WRITE SAME and DISCARD requests are actually aligned to the
logical block size.  Failure to do this causes other errors in other
parts of the block layer or the SCSI layer because disks don't support
partial logical block writes.

Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v9 0/3] fallocate for block devices, Darrick J. Wong [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Darrick J. Wong Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Bart Van Assche Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Darrick J. Wong Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Martin K. Petersen [PATCH 2/3] block: require write_same and discard requests align to logical block size, Darrick J. Wong Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size, Bart Van Assche <= Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size, Martin K. Petersen [PATCH 3/3] block: implement (some of) fallocate for block devices, Darrick J. Wong

Previous by Date:	Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Bart Van Assche
Next by Date:	Re: [PATCH 003/119] xfs: check offsets of variable length structures, Brian Foster
Previous by Thread:	[PATCH 2/3] block: require write_same and discard requests align to logical block size, Darrick J. Wong
Next by Thread:	Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size, Martin K. Petersen
Indexes:	[Date] [Thread] [Top] [All Lists]