xfs
[Top] [All Lists]

Re: [PATCH 4/4] Move to more stdint types

To: Felix Janda <felix.janda@xxxxxxxxx>
Subject: Re: [PATCH 4/4] Move to more stdint types
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 20 Jun 2016 12:12:26 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160618145330.GD17768@nyan>
References: <20160618145330.GD17768@nyan>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Jun 18, 2016 at 04:53:30PM +0200, Felix Janda wrote:
> The uint*_t and int*_t are defined by C99 and should be prefered
> over the less portable __uint*_t and __int*_t variants. The
> necessary <stdint.h> include is in platformdefs.h, which gets
> included in most places via libxfs.h.
> 
> For now, only replace all __uint*_t types to uint*_t and likewise for
> __int*_t outside the directories include/ and libxfs/.
> 
> Signed-off-by: Felix Janda <felix.janda@xxxxxxxxx>
.....
>  58 files changed, 502 insertions(+), 502 deletions(-)

Because of the amount of churn this will cause outstanding patchsets
(e.g. the rmap/reflink work), this isn't the best time for us to be
committing tree-wide cleanups like this. Once we get the major
changes that are pending reviewed and committed I have no problems
with making these changes, so perhaps you could regenerate the patch
once those are merged?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>