| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 003/119] xfs: check offsets of variable length structures |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 17 Jun 2016 04:33:14 -0700 |
| Cc: | david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <146612629195.12839.14090954204243398929.stgit@xxxxxxxxxxxxxxxx> |
| References: | <146612627129.12839.3827886950949809165.stgit@xxxxxxxxxxxxxxxx> <146612629195.12839.14090954204243398929.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Thu, Jun 16, 2016 at 06:18:12PM -0700, Darrick J. Wong wrote: > Some of the directory/attr structures contain variable-length objects, > so the enclosing structure doesn't have a meaningful fixed size at > compile time. We can check the offsets of the members before the > variable-length member, so do those. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Looks fine, and should go in independently of the rmap work: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 001/119] vfs: fix return type of ioctl_file_dedupe_range, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 004/119] xfs: enable buffer deadlock postmortem diagnosis via ftrace, Christoph Hellwig |
| Previous by Thread: | [PATCH 003/119] xfs: check offsets of variable length structures, Darrick J. Wong |
| Next by Thread: | Re: [PATCH 003/119] xfs: check offsets of variable length structures, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |