| To: | david@xxxxxxxxxxxxx, darrick.wong@xxxxxxxxxx |
|---|---|
| Subject: | [PATCH 005/119] xfs: check for a valid error_tag in errortag_add |
| From: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
| Date: | Thu, 16 Jun 2016 18:18:24 -0700 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <146612627129.12839.3827886950949809165.stgit@xxxxxxxxxxxxxxxx> |
| References: | <146612627129.12839.3827886950949809165.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | StGit/0.17.1-dirty |
Currently we don't check the error_tag when someone's trying to set up
error injection testing. If userspace passes in a value we don't know
about, send back an error. This will help xfstests to _notrun a test
that uses error injection to test things like log replay.
Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
fs/xfs/xfs_error.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
index 88693a9..355619a 100644
--- a/fs/xfs/xfs_error.c
+++ b/fs/xfs/xfs_error.c
@@ -61,6 +61,9 @@ xfs_errortag_add(int error_tag, xfs_mount_t *mp)
int len;
int64_t fsid;
+ if (error_tag >= XFS_ERRTAG_MAX)
+ return -EINVAL;
+
memcpy(&fsid, mp->m_fixedfsid, sizeof(xfs_fsid_t));
for (i = 0; i < XFS_NUM_INJECT_ERROR; i++) {
|
| Previous by Date: | [PATCH 004/119] xfs: enable buffer deadlock postmortem diagnosis via ftrace, Darrick J. Wong |
|---|---|
| Next by Date: | [PATCH 006/119] xfs: port differences from xfsprogs libxfs, Darrick J. Wong |
| Previous by Thread: | Re: [PATCH 004/119] xfs: enable buffer deadlock postmortem diagnosis via ftrace, Dave Chinner |
| Next by Thread: | Re: [PATCH 005/119] xfs: check for a valid error_tag in errortag_add, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |