xfs
[Top] [All Lists]

Re: [RFC PATCH-tip 2/6] locking/rwsem: Enable optional count-based spinn

To: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Subject: Re: [RFC PATCH-tip 2/6] locking/rwsem: Enable optional count-based spinning on reader
From: Waiman Long <waiman.long@xxxxxxx>
Date: Tue, 14 Jun 2016 15:11:23 -0400
Authentication-results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@xxxxxxx;
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-alpha@xxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, <linux-arch@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, Jason Low <jason.low2@xxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Scott J Norton <scott.norton@xxxxxxx>, Douglas Hatch <doug.hatch@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160614182757.GA15903@xxxxxxxxxxxxxxx>
References: <1465927959-39719-1-git-send-email-Waiman.Long@xxxxxxx> <1465927959-39719-3-git-send-email-Waiman.Long@xxxxxxx> <20160614182757.GA15903@xxxxxxxxxxxxxxx>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12
On 06/14/2016 02:27 PM, Davidlohr Bueso wrote:
On Tue, 14 Jun 2016, Waiman Long wrote:

This patch provides a way for the kernel code to designate specific
rwsems to be more aggressive in term of optimistic spinning that the
writers will continue to spin for some additional count-based time to
see if it can get the lock before sleeping. This aggressive spinning
mode should only be used on rwsems where the readers are unlikely to
go to sleep.

Yikes, exposing this sort of thing makes me _very_ uneasy, not to mention
the ad-hoc nature and its easiness to mess up. I'm not really for this, even
if it shows extraordinary performance boosts on benchmarks.

Thanks,
Davidlohr

I understand your concern. I will see if there is a way to autotune instead of using explicit enablement.

Cheers,
Longman

<Prev in Thread] Current Thread [Next in Thread>