xfs
[Top] [All Lists]

Re: xfsprogs: Add BUILD_CFLAGS for cross compilation

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfsprogs: Add BUILD_CFLAGS for cross compilation
From: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
Date: Fri, 27 May 2016 09:34:50 -0700
Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=RDoeiUBtahcappPs4cz0B8OgdPfYI2n4dPQunostb6M=; b=QUC7isooqmJi2kdtpMrWF8IhPpQGmlWpMiNm/COU7NXeufRtz5tJgNOYE3GbwWrXel GpmSHWCDvaMFwKGLi2D/rXXXA1M8JKaMExl+ZyfVSWk6qoLCQcUKieRGK9TqvJhVNXMs G9g1J4MO/G9lbSaDHnhQGhg+UmI5h7dPxOqaIrv2k90orGXDAkLCJ7MubEpcsrct4YGd zHGL/iZrlwU/L+cKYd08S4n2as0mLytKrpUZCy4VGxEy8HVJ62jEt3IibsAUQl3y/EZ8 iYXwRkuPMKCAWILgGCTrHlZHGt+PBdcUoFbSDMYKWKYfONDhscq/skyoC9IBUvt1qqh1 5Aaw==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=RDoeiUBtahcappPs4cz0B8OgdPfYI2n4dPQunostb6M=; b=jlwrSLR7gEEUQ75va3AbFqDwjLKq36GCiWON4zjhHeJO/U/fz5gQ24nz+lBhZw4vVm SrkSk1t6MyJO9pCLe1gVTF1mSfsRCskUej3dsfHkr3B+nPfxhM7Zrx+A1OFN0bg46DOB 8EqEQvKGfz81BLIyEyx9rY7xy0IxYnrSL3hoE=
In-reply-to: <20160202180828.GA13880@xxxxxxxxxxxxx>
References: <1437913255-7524-4-git-send-email-tytso@xxxxxxx> <1454361909-36538-1-git-send-email-gwendal@xxxxxxxxxxxx> <20160202180828.GA13880@xxxxxxxxxxxxx>
Sender: gwendal@xxxxxxxxxx
Looking at xfsprogs-4.5.0, that patch has not been applied. Did it not work?
It still applies cleanly on 4.5.

Gwendal.

On Tue, Feb 2, 2016 at 10:08 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
On Mon, Feb 01, 2016 at 01:25:09PM -0800, Gwendal Grignou wrote:
> When cross compiling, CFLAGS may contains option for the cros-compiler the
> host compiler can not handle.
> Add BUILD_CFLAGS variable that does not include $OPTIMIZER options.

I would have expected this to be HOST_CFLAGS, but it seems the
BUILD_ convention already exists in xfsprogs, so sticking to it
looks fine to me.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>