| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/7] xfs/104: don't enospc when ag metadata overhead grows |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 26 May 2016 01:08:35 -0700 |
| Cc: | david@xxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <146424222875.6278.15144771781299434088.stgit@xxxxxxxxxxxxxxxx> |
| References: | <146424222237.6278.4174636124436241002.stgit@xxxxxxxxxxxxxxxx> <146424222875.6278.15144771781299434088.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> +for i in `seq 125 -1 90`; do
> + fillsize=`expr $i \* 1048576`
> + out="$(_fill_scratch $fillsize 2>&1)"
> + echo "$out" | grep -q 'No space left on device' && continue
> + test -n "${out}" && echo "$out"
> + break
> +done
That's a bit of an odd loop, and it would seem an inverted grep
would seem more obvious. But otherwise this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 6/7] xfs: test rmap behavior when multiple bmbt records map to a single rmapbt record, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/7] tests: don't put loop control files on the scratch mount, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/7] xfs/104: don't enospc when ag metadata overhead grows, Darrick J. Wong |
| Next by Thread: | [PATCH 2/7] tests: don't put loop control files on the scratch mount, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |