xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs.h: define XFS_IOC_FREEZE even if FIFREEZE is defined

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/2] xfs.h: define XFS_IOC_FREEZE even if FIFREEZE is defined
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 23 May 2016 17:36:39 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1464015836-25127-2-git-send-email-hch@xxxxxx>
References: <1464015836-25127-1-git-send-email-hch@xxxxxx> <1464015836-25127-2-git-send-email-hch@xxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 5/23/16 10:03 AM, Christoph Hellwig wrote:
> And the same for XFS_IOC_THAW.  Just because we now have a common
> version of the ioctl we still need to provide the old name for it
> for anyone using those.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Makes sense.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  libxfs/xfs_fs.h | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/libxfs/xfs_fs.h b/libxfs/xfs_fs.h
> index b9622ba..1f17e1c 100644
> --- a/libxfs/xfs_fs.h
> +++ b/libxfs/xfs_fs.h
> @@ -542,12 +542,8 @@ typedef struct xfs_swapext
>  #define XFS_IOC_ERROR_CLEARALL            _IOW ('X', 117, struct 
> xfs_error_injection)
>  /*   XFS_IOC_ATTRCTL_BY_HANDLE -- deprecated 118      */
>  
> -/*   XFS_IOC_FREEZE            -- FIFREEZE   119      */
> -/*   XFS_IOC_THAW              -- FITHAW     120      */
> -#ifndef FIFREEZE
> -#define XFS_IOC_FREEZE                    _IOWR('X', 119, int)
> -#define XFS_IOC_THAW              _IOWR('X', 120, int)
> -#endif
> +#define XFS_IOC_FREEZE                    _IOWR('X', 119, int)       /* aka 
> FIFREEZE */
> +#define XFS_IOC_THAW              _IOWR('X', 120, int)       /* aka FITHAW */
>  
>  #define XFS_IOC_FSSETDM_BY_HANDLE    _IOW ('X', 121, struct 
> xfs_fsop_setdm_handlereq)
>  #define XFS_IOC_ATTRLIST_BY_HANDLE   _IOW ('X', 122, struct 
> xfs_fsop_attrlist_handlereq)
> 

<Prev in Thread] Current Thread [Next in Thread>