| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_db: allow recalculating CRCs on invalid metadata |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 23 May 2016 07:52:50 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <ee586739-e804-8174-8497-cc8a992b9752@xxxxxxxxxxx> |
| References: | <1463092513-5462-1-git-send-email-david@xxxxxxxxxxxxx> <ee586739-e804-8174-8497-cc8a992b9752@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Thu, May 12, 2016 at 06:03:15PM -0500, Eric Sandeen wrote: > Using "TYP_NO_CRC_OFF" seems a little weird from a naming perspective; > it's not really a TYP_* is it? Its opposite is things like > XFS_AGI_CRC_OFF; NO_FIXED_CRC_OFF might be better to not confuse it > with the TYP_ on-disk types? Just a thought. Agreed. How about adding a _F inbetween, e.g. TYP_F_NO_CRC_OFF? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs_repair: further improvement on secondary superblock search method, Christoph Hellwig |
|---|---|
| Next by Date: | fix fsxattr redefinitions, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs_db: allow recalculating CRCs on invalid metadata, Eric Sandeen |
| Next by Thread: | [PATCH] db: limit AGFL bno array printing, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |