Re: [PATCH] xfs: make several functions static

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, May 19, 2016 at 02:16:25PM -0500, Eric Sandeen wrote:
> Al Viro noticed that xfs_lock_inodes should be static, and
> that led to ... a few more.
> 
> These are just the easy ones, others require moving functions
> higher in source files, so that's not done here to keep
> this review simple.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---
> 
> We aren't using STATIC anymore ... right?

We're moving away from it at least, although not very stringently..

> FWIW cross-applying to xfsprogs picks up a handful of these
> as well, and it's still happy too.

Yeah - seems like none of them is of the odd static in kernel but not in
xfsprogs kind.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>