| To: | Vishal Verma <vishal.l.verma@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through the driver if possible |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Thu, 12 May 2016 10:38:52 +0200 |
| Cc: | linux-nvdimm@xxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jens Axboe <axboe@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jeff Moyer <jmoyer@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1463000932-31680-6-git-send-email-vishal.l.verma@xxxxxxxxx> |
| References: | <1463000932-31680-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1463000932-31680-6-git-send-email-vishal.l.verma@xxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Wed 11-05-16 15:08:51, Vishal Verma wrote:
> In the truncate or hole-punch path in dax, we clear out sub-page ranges.
> If these sub-page ranges are sector aligned and sized, we can do the
> zeroing through the driver instead so that error-clearing is handled
> automatically.
>
> For sub-sector ranges, we still have to rely on clear_pmem and have the
> possibility of tripping over errors.
>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> Cc: Jeff Moyer <jmoyer@xxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> Cc: Jan Kara <jack@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
The patch looks good to me now. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: remove unused variable warning in xfs_finish_page_writeback, Carlos Maiolino |
|---|---|
| Next by Date: | Re: [PATCH v7 4/6] dax: export a low-level __dax_zero_page_range helper, Jan Kara |
| Previous by Thread: | [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through the driver if possible, Vishal Verma |
| Next by Thread: | [PATCH v7 6/6] dax: fix a comment in dax_zero_page_range and dax_truncate_page, Vishal Verma |
| Indexes: | [Date] [Thread] [Top] [All Lists] |