xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear

from [Jan Kara] [Permanent Link][Original]
To: Vishal Verma <vishal.l.verma@xxxxxxxxx>
Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
From: Jan Kara <jack@xxxxxxx>
Date: Tue, 10 May 2016 16:16:41 +0200
Cc: linux-nvdimm@xxxxxxxxxxxx, Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jens Axboe <axboe@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jeff Moyer <jmoyer@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1462571591-3361-4-git-send-email-vishal.l.verma@xxxxxxxxx>
References: <1462571591-3361-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1462571591-3361-4-git-send-email-vishal.l.verma@xxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30) 
On Fri 06-05-16 15:53:09, Vishal Verma wrote:
> From: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> 
> dax_clear_sectors() cannot handle poisoned blocks.  These must be
> zeroed using the BIO interface instead.  Convert ext2 and XFS to use
> only sb_issue_zerout().
> 
> Signed-off-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> [vishal: Also remove the dax_clear_sectors function entirely]
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>

The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

                                                                Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH v5 1/5] dax: fallback from pmd to pte on error, Jan Kara
Next by Date:  Re: [PATCH v5 4/5] dax: for truncate/hole-punch, do zeroing through the driver if possible, Jan Kara
Previous by Thread:  Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors, Ross Zwisler
Next by Thread:  [PATCH v5 5/5] dax: fix a comment in dax_zero_page_range and dax_truncate_page, Vishal Verma
Indexes:  [Date] [Thread] [Top] [All Lists]