xfs
[Top] [All Lists]

Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear

To: "hch@xxxxxxxxxxxxx" <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
From: "Verma, Vishal L" <vishal.l.verma@xxxxxxxxx>
Date: Sun, 8 May 2016 18:46:13 +0000
Accept-language: en-US
Cc: "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "linux-nvdimm@xxxxxxxxxxx" <linux-nvdimm@xxxxxxxxxxx>, "jmoyer@xxxxxxxxxx" <jmoyer@xxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "Williams, Dan J" <dan.j.williams@xxxxxxxxx>, "axboe@xxxxxx" <axboe@xxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "ross.zwisler@xxxxxxxxxxxxxxx" <ross.zwisler@xxxxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, "boaz@xxxxxxxxxxxxx" <boaz@xxxxxxxxxxxxx>, "Wilcox, Matthew R" <matthew.r.wilcox@xxxxxxxxx>, "david@xxxxxxxxxxxxx" <david@xxxxxxxxxxxxx>, "jack@xxxxxxx" <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160508085203.GA10160@xxxxxxxxxxxxx>
References: <1462571591-3361-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1462571591-3361-4-git-send-email-vishal.l.verma@xxxxxxxxx> <20160508085203.GA10160@xxxxxxxxxxxxx>
Thread-index: AQHRp+HM2eoEbh124kig/gT9Mjt4V5+vM12AgACmAoA=
Thread-topic: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
On Sun, 2016-05-08 at 01:52 -0700, Christoph Hellwig wrote:
> On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote:
> > 
> > From: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> > 
> > dax_clear_sectors() cannot handle poisoned blocks.ÂÂThese must be
> > zeroed using the BIO interface instead.ÂÂConvert ext2 and XFS to
> > use
> > only sb_issue_zerout().
> > 
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> > [vishal: Also remove the dax_clear_sectors function entirely]
> > Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> Just to make sure:ÂÂthe existing sb_issue_zerout as in 4.6-rc
> is already doing the right thing for DAX?ÂÂI've got a pending
> patchset
> for XFS that introduces another dax_clear_sectors users, but if it's
> already safe to use blkdev_issue_zeroout I can switch to that and
> avoid
> the merge conflict.

I believe so - Jan has moved all unwritten extent conversions out of
DAX with his patch set, and I believe zeroing through the driver is
always fine. Ross or Jan could confirm though.Â
<Prev in Thread] Current Thread [Next in Thread>