xfs
[Top] [All Lists]

Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear

To: Vishal Verma <vishal.l.verma@xxxxxxxxx>
Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 8 May 2016 01:52:03 -0700
Cc: linux-nvdimm@xxxxxxxxxxx, Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jens Axboe <axboe@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jeff Moyer <jmoyer@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1462571591-3361-4-git-send-email-vishal.l.verma@xxxxxxxxx>
References: <1462571591-3361-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1462571591-3361-4-git-send-email-vishal.l.verma@xxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote:
> From: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> 
> dax_clear_sectors() cannot handle poisoned blocks.  These must be
> zeroed using the BIO interface instead.  Convert ext2 and XFS to use
> only sb_issue_zerout().
> 
> Signed-off-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> [vishal: Also remove the dax_clear_sectors function entirely]
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>

Just to make sure:  the existing sb_issue_zerout as in 4.6-rc
is already doing the right thing for DAX?  I've got a pending patchset
for XFS that introduces another dax_clear_sectors users, but if it's
already safe to use blkdev_issue_zeroout I can switch to that and avoid
the merge conflict.

<Prev in Thread] Current Thread [Next in Thread>