xfs
[Top] [All Lists]

Re: [PATCH 03/19] mkfs: Sanitise the superblock feature macros

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 03/19] mkfs: Sanitise the superblock feature macros
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 3 May 2016 19:48:39 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <295ccd50-c22e-59d0-71d9-b07b438f63cd@xxxxxxxxxxx>
References: <1461231593-31294-1-git-send-email-jtulak@xxxxxxxxxx> <1461231593-31294-4-git-send-email-jtulak@xxxxxxxxxx> <295ccd50-c22e-59d0-71d9-b07b438f63cd@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.0
Patch 03/19 fixup V2:

sb_feat.dirftype should be initialized as true, not initialized
as false and then reset to 1 (sic - true)

V2: Remove unnecessary continuation chars "\"

Eric Sandeen <sandeen@xxxxxxxxxx>: Properly initialize sb_feat.dirftype
---

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 963545b..e19181c 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -975,8 +975,7 @@ sb_set_features(
         */
        if (fp->spinodes) {
                sbp->sb_spino_align = sbp->sb_inoalignmt;
-               sbp->sb_inoalignmt = \
-                       XFS_INODES_PER_CHUNK * \
+               sbp->sb_inoalignmt = XFS_INODES_PER_CHUNK *
                        sbp->sb_inodesize >> sbp->sb_blocklog;
                sbp->sb_features_incompat |= XFS_SB_FEAT_INCOMPAT_SPINODES;
        }
@@ -1090,7 +1089,7 @@ main(
                .lazy_sb_counters = true,
                .projid16bit = false,
                .crcs_enabled = true,
-               .dirftype = false,
+               .dirftype = true,
                .parent_pointers = false,
        };
 
@@ -1109,7 +1108,6 @@ main(
        liflag = laflag = lsflag = lsuflag = lsunitflag = ldflag = lvflag = 0;
        loginternal = 1;
        logagno = logblocks = rtblocks = rtextblocks = 0;
-       sb_feat.dirftype = 1;           /* inode type information in the dir */
        Nflag = nlflag = nsflag = nvflag = 0;
        nftype = 0;
        dirblocklog = dirblocksize = 0;

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>