| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 11/19] mkfs: table based parsing for converted parameters |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Mon, 2 May 2016 18:09:40 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1461231593-31294-12-git-send-email-jtulak@xxxxxxxxxx> |
| References: | <1461231593-31294-1-git-send-email-jtulak@xxxxxxxxxx> <1461231593-31294-12-git-send-email-jtulak@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
The kernel enforces a max of XLOG_MAX_RECORD_BSIZE,
and it should match the limits in L_SUNIT after all ...
Eric Sandeen <sandeen@xxxxxxxxxx>: fix min/max for "-l su"
---
su and sunit are ultimately setting the same parameter; their
limits should be the same.
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 0d28a84..3ffae42 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -395,8 +395,8 @@ struct opt_params lopts = {
},
{ .index = L_SU,
.convert = true,
- .minval = 0,
- .maxval = UINT_MAX,
+ .minval = XLOG_MIN_RECORD_BSIZE,
+ .maxval = XLOG_MAX_RECORD_BSIZE,
.defaultval = SUBOPT_NEEDS_VAL,
},
{ .index = L_DEV,
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 08/19] mkfs: getbool is redundant, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 13/19] mkfs: encode conflicts into parsing table, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 08/19] mkfs: getbool is redundant, Eric Sandeen |
| Next by Thread: | Re: [PATCH 13/19] mkfs: encode conflicts into parsing table, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |