xfs
[Top] [All Lists]

Re: [PATCH 08/19] mkfs: getbool is redundant

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 08/19] mkfs: getbool is redundant
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 2 May 2016 18:08:18 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1461231593-31294-9-git-send-email-jtulak@xxxxxxxxxx>
References: <1461231593-31294-1-git-send-email-jtulak@xxxxxxxxxx> <1461231593-31294-9-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.0
Remove manpage changes, tidy others

Tidy up the grammar a little in the boolean args description.

Remove extra text around the noalign option.

It's fine that the noalign option now takes an optional
boolean 0/1 argument, but I don't think we need to document
it in the manpage.  If someone happens to add "=1" and it works,
they'll just be pleasantly surprised.


Eric Sandeen <sandeen@xxxxxxxxxx>: manpage tidiness
---

diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index be3d1a0..980b0e1 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -119,7 +119,7 @@ option first needs to be added to the command line.
 Failure to specify the size of the units will result in illegal value errors
 when parameters are quantified in those units.
 .PP
-Many options allows for optional argument of value 0 or 1, to explicitly
+Many feature options allow an optional argument of 0 or 1, to explicitly
 disable or enable the functionality.
 .SH OPTIONS
 .TP
@@ -315,12 +315,10 @@ and
 .B swidth
 values.
 .TP
-.BI noalign[= value ]
-If the
-.I value
-is 1, this option disables automatic geometry detection and creates the 
filesystem
+.BI noalign
+This option disables automatic geometry detection and creates the filesystem
 without stripe geometry alignment even if the underlying storage device 
provides
-this information. 0 disables this option, that is, enables automatic detection.
+this information.
 .RE
 .TP
 .B \-f
@@ -810,11 +808,9 @@ This suboption is only needed if the real-time section of 
the
 filesystem should occupy less space than the size of the partition
 or logical volume containing the section.
 .TP
-.BI noalign[= value ]
-If the
-.I value
-is 1, then the option disables stripe size detection, enforcing a realtime
-device with no stripe geometry. 0 will enable stripe size detection.
+.BI noalign
+This option disables stripe size detection, enforcing a realtime device with no
+stripe geometry.
 .RE
 .TP
 .BI \-s " sector_size"


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 08/19] mkfs: getbool is redundant, Eric Sandeen <=